[12.0][FIX] Improved code of stage create method. #643
Conversation
There was a problem hiding this comment.
@rutul-serpentcs
This fixes the original error you presented.
However there is still an issue creating the stage from Kanban view
The operation cannot be completed:
- Create/update: a mandatory field is not set.
- Delete: another model requires the record being deleted. If possible, archive it instead.
Model: Field Service Stage (fsm.stage), Field: Type (stage_type)
stage_type field needs to be set
brian10048
requested review from
osi-scampbell,
dreispt,
bodedra,
max3903,
brian10048 and
marcelsavegnago
@brian10048 Done, Can you please review it again? |
|
@rutul-serpentcs - It allows to create the stage, but a new bug is introduced when we create a stage that has an undefined stage type. When you go back to the orders kanban view, the stage recently created will not be displayed. Can you revert the recent change and keep the stage_type required in python? Then, instead can you use the context to set the correct |
rutul-serpentcs
force-pushed
the
12.0_FIX_fieldservice
branch
from
12648da
to
b21997b
Compare
| @@ -45,8 +45,7 @@ def _default_team_ids(self): | |||
| stage_type = fields.Selection([('order', 'Order'), | |||
| ('equipment', 'Equipment'), | |||
| ('location', 'Location'), | |||
| ('worker', 'Worker')], 'Type', | |||
| required=True) | |||
| ('worker', 'Worker')], 'Type', require=True) | |||
There was a problem hiding this comment.
I'm afraid this is incorrect, required is the correct field attribute.
Is the goal to remove the required attribute?
| @@ -13,7 +13,8 @@ | |||
| <field name="name">Orders</field> | |||
| <field name="res_model">fsm.order</field> | |||
| <field name="view_mode">kanban,timeline,tree,form,calendar</field> | |||
| <field name="context">{'default_team_id': active_id}</field> | |||
| <field name="context">{'default_team_id': active_id, | |||
| 'default_stage_type':'order'}</field> | |||
There was a problem hiding this comment.
| 'default_stage_type':'order'}</field> | |
| 'default_stage_type': 'order'}</field> |
| if stage.stage_type == vals['stage_type'] and \ | ||
| stage.sequence == vals['sequence']: | ||
| if stage.stage_type == vals.get('stage_type') and \ | ||
| stage.sequence == vals.get('sequence'): |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
brian10048
added
no stale
When I create stage from Field Service >> Dashboard >> Team >> Orders kanban view I got an error.